dhiaayachi
commented
1 week ago Thank you for reporting this issue.
It seems that you are experiencing an issue with Temporal 1.21.4 where your workflow is receiving signals that it is not expecting.
Based on the provided error message and the logs, it appears that the workflow is failing to handle a signal named "test-unhandled-signal-name". This suggests that the workflow definition does not have a corresponding signal handler for this signal.
To resolve this issue, you need to add a signal handler for the test-unhandled-signal-name signal to your workflow definition. This can be done using the SignalMethod annotation in the Signal method.
Here is an example of how to add a signal handler for the test-unhandled-signal-name signal:
import (
"context"
"github.com/temporalio/temporal/client"
"github.com/temporalio/temporal/common/log"
"github.com/temporalio/temporal/service/worker"
"github.com/temporalio/temporal/workflow"
)
type MyWorkflow struct {
}
func (t *MyWorkflow) Signal(ctx workflow.Context, signalName string, input interface{}) error {
switch signalName {
case "test-unhandled-signal-name":
// Handle the signal here
log.Info(ctx, "Received test-unhandled-signal-name signal")
return nil
default:
return workflow.ErrSignalNotSupported
}
}
func main() {
c, err := client.NewClient(client.Options{
// ...
})
if err != nil {
panic(err)
}
defer c.Close()
w := worker.New(c, "MyWorkflowWorker", worker.Options{
// ...
})
w.RegisterWorkflowWithOptions(MyWorkflow{}, worker.RegisterWorkflowOptions{
Name: "MyWorkflow",
})
w.Run(context.Background())
}For more information on how to handle signals in Temporal, please refer to the Temporal documentation: https://docs.temporal.io/docs/concepts/signals
Such a requirement could be very inconvenient and could require in-compatible change in user workflow code.
Expected Behavior
Only WFT that closing workflow should be required to handle all signals.
Actual Behavior
It started to require at 1.21.4 version
Steps to Reproduce the Problem
In my PR: When changing the server version to 1.21.4 from 1.20.4 it fails https://github.com/indeedeng/iwf/pull/336/commits/6e858321b7af12d5be20cf4f9992213b6d333b23 with error in the logs:
Specifications