dhiaayachi / temporal

Temporal service
https://docs.temporal.io
MIT License
0 stars 0 forks source link

Add sender info to Signal initiated through SignalExternalWorkflowExecution #397

Open dhiaayachi opened 2 weeks ago

dhiaayachi commented 2 weeks ago

Is your feature request related to a problem? Please describe. WorkflowExecutionSignaledEvent contains no reference to a workflow that sent the signal. For example:

    {
      "eventId": "71",
      "eventTime": "2023-02-23T17:19:23.051982830Z",
      "eventType": "WorkflowExecutionSignaled",
      "version": "0",
      "taskId": "265937709",
      "workerMayIgnore": false,
      "workflowExecutionSignaledEventAttributes": {
        "signalName": "endWorkflowSignal",
        "input": null,
        "identity": "history-service",
        "header": null
      }
    },

Describe the solution you'd like WorkflowExecutionSignaled has a field that contains workflowID and runID of the workflow that sent the signal.

Describe alternatives you've considered A temporary workaround would be populating the identity field with this information. This is not ideal as this field is just text.

dhiaayachi commented 1 day ago

Thank you for reporting this issue. This is a known issue that has been tracked here: https://github.com/temporalio/temporal/issues/4014.

dhiaayachi commented 1 day ago

Thank you for reporting this issue. You are correct; the WorkflowExecutionSignaledEvent doesn't currently include the workflow ID and run ID of the workflow that sent the signal.

We appreciate your proposed solution of adding workflowID and runID fields to the WorkflowExecutionSignaledEvent. This would provide valuable information for debugging and tracing signal events. In the meantime, consider using the identity field for your temporary workaround as suggested.

We will consider this feature request for a future release of Temporal.

dhiaayachi commented 1 day ago

Thank you for reporting this! I understand the need to have access to the source workflow ID and run ID when handling WorkflowExecutionSignaledEvent. This is currently not supported and the identity field is not suitable for this purpose. We are looking into adding this feature in the future.

In the meantime, you can use the workaround you suggested by populating the identity field with the workflow ID and run ID. This is not ideal, but it will provide you with the information you need.

If this workaround does not work for your use case or you have any further feedback, please let us know. We appreciate your input!