search

dhiltgen / docker-machine-kvm

KVM driver for docker-machine
Apache License 2.0
376 stars 117 forks source link

The current domain XML used for the KVM driver does not specify a CPU mode... #32

Closed caiobegotti closed 7 years ago

caiobegotti commented 7 years ago

…which makes things very slow and usually lead to a constant >25% CPU usage for people using your driver with Kubernetes and Minikube. This solves the problem as it simply tells KVM to use everything the host supports and emulate whatever else is needed.

See http://wiki.qemu.org/Features/CPUModels#-cpu_host_and_feature_probing for more info. CPU host mode is usually safe and recommended for scenarios like the ones this driver is used for. The only limitation (which I suspect is not a big deal here) is that if KVM migrations between hosts of different CPUs models are too frequent.

caiobegotti commented 7 years ago

@dhiltgen Do you think it would be possible to tag a v0.7.1 release after this lands? This way Kubernetes and Minikube folks can test a released tarball with the fix!

caiobegotti commented 7 years ago

Hey there @dhiltgen, did you have a chance to look at this PR? :-)

caiobegotti commented 7 years ago

Sorry to bother @dhiltgen but... ping?

dhiltgen commented 7 years ago

Sorry for the delay, and thanks for the ping. Gave this a spin and it looks good.