search

dhiltgen / docker-machine-kvm

KVM driver for docker-machine
Apache License 2.0
377 stars 117 forks source link

Fix connection reference on NewDriver #5

Closed rsampaio closed 8 years ago

rsampaio commented 8 years ago

This fix the driver initialization caused by d.connectionString not being initialized when the Driver is created, this will make subsequent calls use qemu:///session instead of qemu:///system and network.Create will fail with this message.

(local-kvm) DBG | Reactivating private network: %!s(<nil>)
Error creating machine: Error with pre-create check: [Code-38] [Domain-0] error creating bridge interface virbr0: Operation not permitted

Also changed the function signature to match with what is used in other driver, not related to the issue though.

docteurklein commented 8 years ago

I just hit the same error.

dhiltgen commented 8 years ago

Thanks! - I've resolved the merge conflict and pushed this to master.