search

dhiltgen / docker-machine-kvm

KVM driver for docker-machine
Apache License 2.0
376 stars 117 forks source link

Allow to pass a different url for contacting libvirt #63

Closed karmab closed 4 years ago

karmab commented 6 years ago

this adds new parameters:

the corresponding attribute (d.ConnectionString), capitalized for that matter is now exposed in the config of the vm (to allow post creation operations on the vm). uploading of the bootdocker iso and custom image file is done using the libvirt api additionally , we use an alternative to retrieve the ip of the vm by checking leases server side and also make sure the uploaded image gets properly deleted upon removal of the vm

Vanuan commented 5 years ago

Is there a prebuilt version with this patch somewhere?

karmab commented 5 years ago

https://github.com/karmab/docker-machine-kvm-patched/blob/master/docker-machine-driver-kvm-centos7

El El mar, 18 sept 2018 a las 11:52, John Yani notifications@github.com escribió:

Is there a prebuilt version with this patch somewhere?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dhiltgen/docker-machine-kvm/pull/63#issuecomment-422330404, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwVAysrFzMgUBYkV985wpZ8ftR8k4QFks5ucMJjgaJpZM4QU31h .

-- Karim,

Vanuan commented 5 years ago

I've just tested it, and it doesn't seem to work:

(testVM2) Creating SSH key...
Error creating machine: Error in driver during machine creation: Panic in the driver: runtime error: invalid memory address or nil pointer dereference
goroutine 45 [running]:
runtime/debug.Stack(0xc4201ab638, 0x4169f7, 0x7f1fe8000ce0)
    /usr/local/go/src/runtime/debug/stack.go:24 +0x79
github.com/docker/machine/libmachine/drivers/rpc.(*StandardStack).Stack(0xd65880, 0x87c600, 0xd10620, 0xd20d40)
    /go/src/github.com/docker/machine/libmachine/drivers/rpc/server_driver.go:23 +0x22
github.com/docker/machine/libmachine/drivers/rpc.trapPanic(0xc4201abae0)
    /go/src/github.com/docker/machine/libmachine/drivers/rpc/server_driver.go:129 +0xa5
panic(0x87c600, 0xd10620)
    /usr/local/go/src/runtime/panic.go:489 +0x2cf
github.com/libvirt/libvirt-go.(*StoragePool).Refresh(0x0, 0xc400000000, 0x7, 0x0)
    /go/src/github.com/libvirt/libvirt-go/storage_pool.go:276 +0x26
github.com/dhiltgen/docker-machine-kvm.(*Driver).Create(0xc420148000, 0x910260, 0xc42003fae0)
    /go/src/github.com/dhiltgen/docker-machine-kvm/kvm.go:446 +0x547
github.com/docker/machine/libmachine/drivers/rpc.(*RPCServerDriver).Create(0xc420136080, 0xd65b50, 0xd65b50, 0x0, 0x0)
    /go/src/github.com/docker/machine/libmachine/drivers/rpc/server_driver.go:140 +0x78
reflect.Value.call(0xc42014a0c0, 0xc420142150, 0x13, 0x8f2820, 0x4, 0xc42003ff20, 0x3, 0x3, 0x2, 0x420144, ...)
    /usr/local/go/src/reflect/value.go:434 +0x91f
reflect.Value.Call(0xc42014a0c0, 0xc420142150, 0x13, 0xc420032720, 0x3, 0x3, 0xc420032718, 0x44efe1, 0xc420068340)
    /usr/local/go/src/reflect/value.go:302 +0xa4
net/rpc.(*service).call(0xc420138580, 0xc4201380c0, 0xc42016a080, 0xc42013ee00, 0xc42015c620, 0x843280, 0xd65b50, 0x16, 0x843280, 0xd65b50, ...)
    /usr/local/go/src/net/rpc/server.go:387 +0x144
created by net/rpc.(*Server).ServeCodec
    /usr/local/go/src/net/rpc/server.go:481 +0x404

My machine version is this: docker-machine version 0.14.0, build 89b8332

Vanuan commented 5 years ago

And I can't delete it:

(testVM2) Failed to fetch machine
Error removing host "testVM2": unexpected EOF
Vanuan commented 5 years ago

docker-machine rm -f testVM2 helps