VirtualBox support - Githubissues

dhinakg / vm-rpc

Discord RPC for VMs.

MIT License

43 stars 6 forks source link

Closed TheM8thy closed 1 year ago

TheM8thy commented 1 year ago

Added VirtualBox support

dhinakg commented 1 year ago

Currently busy rn, I'll take a look when I'm free

dhinakg commented 1 year ago

@set-reminder 1 week look at PR

octo-reminder[bot] commented 1 year ago

⏰ Reminder Saturday, May 20, 2023 12:00 AM (GMT-04:00)

look at PR

octo-reminder[bot] commented 1 year ago

🔔 @dhinakg

look at PR

TheM8thy commented 1 year ago

@dhinakg Did you have any chance to look at it yet?

dhinakg commented 1 year ago

Sorry about the delay - I've been hammered with Sonoma work.

I just want to note two things before I look at this:

I don't have VirtualBox, so I won't be able to test this
I wrote this code years ago, when I barely had any familiarity with Python. Since then, I've progressed a lot and picked up a bunch of design paradigms. So I'm most likely going to end up rewriting the whole thing lol

Considering that, I will review this PR tomorrow

dhinakg commented 1 year ago

Thanks!