dhis2 / app-platform

DHIS 2 application platform layer with inverted app control
https://platform.dhis2.nu
BSD 3-Clause "New" or "Revised" License
27 stars 16 forks source link

fix: fixed plugin dimensions [LIBS-634] #858

Closed tomzemp closed 4 months ago

tomzemp commented 4 months ago

See https://dhis2.atlassian.net/jira/software/c/projects/LIBS/issues/LIBS-634

This PR updates the styling around a plugin loaded by a shell:

Previously, plugins without resizing logic "skipped" the resizing logic (e.g. resizing observer not set up), but I kept (for consistency/simplicity) the extra wrapper divs in the expectation that they would not have issues. From a visual perspective, the wrapper divs don't do anything, but they are apparently preventing highcharts charts from executing their own resizing logic when used in dashboards.

Checked with dashboard/data visualizer, and this new implementation seems to resolve issue: vis_plugin_highcharts

dhis2-bot commented 4 months ago

:tada: This PR is included in version 11.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

dhis2-bot commented 4 months ago

:tada: This PR is included in version 12.0.0-alpha.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: