dhis2 / app-platform

DHIS 2 application platform layer with inverted app control
https://platform.dhis2.nu
BSD 3-Clause "New" or "Revised" License
27 stars 16 forks source link

fix: change dhis/ui to a peer dependency #892

Open kabaros opened 1 week ago

kabaros commented 1 week ago

I am unable to validate this change locally, and the best way I can think of is to merge it to alpha and try it from there.

My assumption is that clients would need to install @dhis2/ui, but I think that's ok (and that's what the majority of projects do anyhow) and it's better than having to dedupe or add a resolution every time there is an update to app-platform.

It's hard to test locally because right now, the shell is a dependency of cli-app-scripts and the UI library is a dependency of the shell. If I run a local version of init script, then it uses the published cli-app-scripts. I can change that manually to use a local version published from yalc, but then that still gets the shell from the published version. Having two levels of yalc dependencies (i.e. cli-app-scripts published through yalc, while using app-shell that's also published through yalc) doesn't quite work. If anyone has an idea of how this can be tested locally then let me know!