Issue #15 General Resusable Snackbar and Connection Utility for Slow or No Internet

dhis2 / dhis2-android-dashboard

:no_entry: [DEPRECATED] Android application for DHIS2 which implements basic dashboard functionality.

BSD 3-Clause "New" or "Revised" License

17 stars 47 forks source link

Issue #15 General Resusable Snackbar and Connection Utility for Slow or No Internet #24

Closed laavanyebahl closed 8 years ago

laavanyebahl commented 8 years ago

Issue no #15

Snackbar for "Slow" or "No" Internet
Can be used in any Activity or Fragment
Login Activity : Check connection on Login Button click
Dashboard Fragment : Check connection on Creation of Fragment and on Refresh button click

screenshot_2016-03-05-15-23-04

screenshot_2016-03-05-15-21-27

erlingfjelstad commented 8 years ago

@laa-1-yay You shouldn't ping Google to check if the device has Internet access. You should let the app try to sync, and if it fails you should provide a callback method and notify the fragment that it hasn't Internet connection.

laavanyebahl commented 8 years ago

@erlingfjelstad Thanks for the guidance. I've implemented the things you suggested and have submitted a pull request for the same : https://github.com/dhis2/dhis2-android-dashboard/pull/35 @ArazAbishov Please review and merge the new pr if it solves the bug now.

arazabishov commented 8 years ago

@laa-1-yay Thank you. Closing this pull-request in favor of https://github.com/dhis2/dhis2-android-dashboard/pull/35.