Issue #12 Animations between fragments of Nav Drawer and DetailsActivity Transition

dhis2 / dhis2-android-dashboard

:no_entry: [DEPRECATED] Android application for DHIS2 which implements basic dashboard functionality.

BSD 3-Clause "New" or "Revised" License

17 stars 47 forks source link

Issue #12 Animations between fragments of Nav Drawer and DetailsActivity Transition #25

Closed laavanyebahl closed 7 years ago

laavanyebahl commented 8 years ago

Issue no #12 Animations

Onclick of content of Dashboard Element which opens Details Activity ( Slide+ Fade in, Slide+ Fade out )
Between Fragments of Nav Drawer (Fade in , Fade out)

2016_03_06_03_36_54_hga8jd

arazabishov commented 8 years ago

@laa-1-yay

Thank you for submitting one more pull-request. The only problem I see here is that fade in/out animations visually slow down navigation between fragments in MenuActivity. Animation used in DashboardElementDetailActivity looks great.

laavanyebahl commented 8 years ago

@ArazAbishov Thanks for reviewing. Should I remove the animation between fragments of Nav Drawer and just send a pr for the DashboardElementDetailActivity ? Should I put some other animations instead between fragments of Nav Drawer ?

arazabishov commented 8 years ago

@laa-1-yay i think it will be better just to remove animations between fragments in navigation drawer.