Issue #3 fixed. - Githubissues

dhis2 / dhis2-android-dashboard

:no_entry: [DEPRECATED] Android application for DHIS2 which implements basic dashboard functionality.

BSD 3-Clause "New" or "Revised" License

17 stars 47 forks source link

Issue #3 fixed. #27

Closed NateshR closed 8 years ago

NateshR commented 8 years ago

ViewPager observe changes now on adding and deleting dashboards. FragmentStatePageAdapter implemented. Smooth scroll to the added or removed dashboard. onLoadFinished in DashboardViewPagerFragment is called twice and it is necessary to be called twice, first when saved dashboard locally and second when synced from server. But reflecting added or removed dashboard is called once only, the second time it just updates the data in DashboardAdapter.

NateshR commented 8 years ago

Issue #1 fixed.

arazabishov commented 8 years ago

Hi @NateshR,

Thank you for contribution. Some comments regarding pull-request:

changes in dashboards table should be pushed through ContentProvider mechanism, not EventBus.
pull-request is huge (touches too many files).

Could you please adjust it according to comments and re-submit?

Thanks.

NateshR commented 8 years ago

Event bus is used to notify only. let me send another pull request, no idea why it's showing so many files.

NateshR commented 8 years ago

I was comparing it with master, that's why it was showing 301 files changed.

NateshR commented 8 years ago

New pull request for this #30

arazabishov commented 8 years ago

@NateshR Closing this pull-request in favor of https://github.com/dhis2/dhis2-android-dashboard/pull/30