search

dhis2 / dhis2-android-dashboard

:no_entry: [DEPRECATED] Android application for DHIS2 which implements basic dashboard functionality.
BSD 3-Clause "New" or "Revised" License
17 stars 47 forks source link

Revised Issue #9 Added Account Edit Fragment and use POJO in controller #37

Closed krishnarb3 closed 7 years ago

krishnarb3 commented 8 years ago

Revised #9 I have made the discussed changes.

-> MenuActivity

Added EventBus onUiEventRecieved for editing user account in fragment Added onBackPressed for fragment transaction from edit account fragment to display account fragment

->AccountEditFieldAdapter

Not display error in editText when email is valid EdittextListener doesnt listen for fields other than Email

->UiEvent : added new UiEvent USER_ACCOUNT_EDIT ->Changed from EditAccount Activity to AccountEditFragment ->Account Fragment : on clicking edit button post UiEvent USER_ACCOUNT_EDIT to EventBus

->Increment recyclerView Library dependency to v7.23.1.1

Causes Bugs (MotionEvent causes NullPointerException) otherwise

@ArazAbishov : Please acknowledge if there are any changes to be made.

arazabishov commented 8 years ago

@krishnarb3 Hi Krishna, I will review your changes as soon as possible and will publish feedback here.

krishnarb3 commented 8 years ago

@ArazAbishov Thank you , Sir

krishnarb3 commented 8 years ago

@ArazAbishov I have added a new commit with working Account Manager Solves Issue #10 Basic testing of Account Manager done , extensive testing ongoing to prevent bugs.

krishnarb3 commented 8 years ago

Please review the code and suggest changes. Thank you.

arazabishov commented 8 years ago

Hi @krishnarb3,

We are currently working on completely new version of dashboard app based on DHIS 2 android SDK. SDK itself already contains profile fragment implementation which we are planning to re-use in dashboard app as well.

What we can do is to take some bits and pieces of your implementation which can complete SDK's profile fragment (you can also do this if you want). I recommend you to take a look into https://github.com/dhis2/dhis2-android-eventcapture repository in order to get better understanding of what we have already done.

Thanks a lot for you contribution!