Closed devikamehra closed 7 years ago
Guys
Why do we want animation here? Everyday we get complaints this module so so so slow.. I'm sorry to say, but nobody like this module
On Wednesday, 23 March 2016, Devika Mehra notifications@github.com wrote:
Animation has been added while
- Attaching and detaching fragments
- Loading RecyclerView items in Dashboard, Interpretation and Account detail fragments.
- Comment Section
- Entry and Exit of DialogFragments
- Entry of the list items of SearchDialogFragement
JavaDocs have been added to notify the changes made and to explain them
thoroughly.
You can view, comment on, or merge this pull request online at:
https://github.com/dhis2/dhis2-android-dashboard/pull/40 Commit Summary
- Animation added to almost all Fragments, DialogFraments and RecyclerView Items
File Changes
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/activities/InterpretationCommentsActivity.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-0 (1)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/activities/MenuActivity.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-1 (1)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/adapters/AccountFieldAdapter.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-2 (34)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/adapters/DashboardItemAdapter.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-3 (53)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/adapters/DashboardItemSearchDialogAdapter.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-4 (39)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/adapters/InterpretationAdapter.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-5 (47)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/adapters/InterpretationCommentsAdapter.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-6 (34)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/dashboard/DashboardAddFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-7 (8)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/dashboard/DashboardItemAddFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-8 (10)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/dashboard/DashboardManageFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-9 (8)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/interpretation/InterpretationCommentEditFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-10 (8)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/interpretation/InterpretationCreateFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-11 (8)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/interpretation/InterpretationTextEditFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-12 (8)
- M app/src/main/java/org/hisp/dhis/android/dashboard/ui/fragments/interpretation/InterpretationTextFragment.java https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-13 (8)
- A app/src/main/res/anim/fade_in.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-14 (10)
- A app/src/main/res/anim/fade_out.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-15 (10)
- M app/src/main/res/anim/in_down.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-16 (2)
- A app/src/main/res/anim/slide_in_bottom.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-17 (16)
- A app/src/main/res/anim/slide_in_left.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-18 (15)
- A app/src/main/res/anim/slide_in_right.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-19 (15)
- A app/src/main/res/anim/slide_in_top.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-20 (16)
- A app/src/main/res/anim/slide_out_bottom.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-21 (13)
- M app/src/main/res/values/styles.xml https://github.com/dhis2/dhis2-android-dashboard/pull/40/files#diff-22 (10)
Patch Links:
- https://github.com/dhis2/dhis2-android-dashboard/pull/40.patch
- https://github.com/dhis2/dhis2-android-dashboard/pull/40.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/dhis2/dhis2-android-dashboard/pull/40
Morten Olav Hansen Senior Engineer, DHIS 2 University of Oslo http://www.dhis2.org
Animation has been added while
JavaDocs have been added to notify the changes made and to explain them thoroughly.