@Mohammer5's current status

[Mohammer5]

As i'm on vacation for quite some time soon (From 21.12.20 until 31.01.21), I've collected the current tasks I'm working on. I've tried to capture the intentions and the current state. If there's something unclear or missing, please ping me so I can update the list below.

Cypress

Hendrik and I are currently working on this repository and there are some major changes coming

• [ ] Restructure install command
  • Jira
  • [ ] CLI-17: Improve install command so we can easily add functionality
  • PRs
  • cli-utils-cypress: Restructure command
  • Branches
  • Restructure_install_cmd
  • allow partial upgrades to existing cypress projects
  • reduce difficulty to add new features, such as plugins or setups
  • currently template files are being copied, the new version will allow more granular control so you can specify which addons you'd like to use. The command will use codemods to alter the actual files (plugin and support files)
  • introduce a dedicated plugin package (@dhis2/cypress-plugins)
  • This way we can control what plugins should be imported and how they should be setup through codemods which will alter the import statement and add plugin calls to the exported function's body
  • add developer documentation
  • I've already added user documentation, but I'd also like to add dev docs to explain the structure, intention, etc
  • use groups similarly to the available groups of then d2 style install command
• [ ] Extract the special data-test selector syntax into their own commands
  • Jira
  • [ ] CLI-11 (EPIC): Restructure helpers & add docs and codemods
    • [x] CLI-13: Add documentation & guides
    • [x] CLI-14: Autoregister commands
    • [x] CLI-12: Create codemod for get/find replacement commands
    • [ ] CLI-10: Add new comands instead of overwriting "get" and "find"
  • PRs
  • cli-utils-codemods: Codemods CLI tool
  • cli-utils-cypress: Rename get/find calls codemod
  • Branches
  • cli-utils-codemods: CLI-10_Turn_into_cli_utility_V2
  • cli-utils-cypress: CLI-12_Replace_get-find_codemod
  • The main goal is to nudge devs to use the helper functions instead of commands
  • This will allow devs to use the alternative selector syntax in all commands that accept a selector, e. g. jQuery's parents method
  • To provide backward compatibility (more or less), we'll be providing codemods to update the cypress test code
  • The codemods should only rename the get and find calls that actually use the custom selector syntax

Codemods

This repository will be changed in order to have a cli util bundled with our d2 cli utils. The main work is closely related to the cypress work, so you'll find the stuff that I'm working on under the Cypress headline

SMS Configuration app

The app is functional, but as multiple developers have worked on this in parallel, we still need to refactor this app to reduce duplicate code, make behavior consistent and refine the codebase to be more clear/maintainable. The app also lacks tests for some sections, which should be implemented first before refactoring the code so we can ensure that we don't break the app.

• [ ] Cover remaining sections with tests
  • Jira
  • [ ] TECH-466 (EPIC): Technical debt: Cover sms configuration app with tests
    • [x] TECH-468: Fix tests for gateway configuration section
    • [x] TECH-469: Fix tests for sms commands section
    • [ ] TECH-470: Fix tests for received sms section
    • [ ] TECH-471: Fix tests for sent sms section
    • [ ] TECH-515: Add tests for sms command list view
  • Branches
  • TECH-470_Tests_for_received_sms_section
  • The following tests are still missing:
    1. Commands section list view (making sure the functionality on the list view works as expected)
    2. Entire received sms section
    3. Entire sent sms section
• [ ] Refactor the codebase
  • Jira
  • [ ] TECH-465 (EPIC): Technical debt: Refactor sms configuration app
  • As this step is still a bit further away, we haven't made any descisions on what we actually want to do here

UI

• [ ] Add scroll to top functionality to the Transfer component
  • Jira
  • LIBS-70
  • Branches
  • Transfer_scroll_to_top
  • The plan
  • The idea is to add a cursor prop which is the amount of displayed pages. The Transfer component should scroll to the top when this prop changes to 0 (which means that there were multiple pages displayed previously (otherwise there wouldn't be a change) and that a new option set is being displayed (as there wouldn't be any other reason to change this to 0 as of now)). The app using this component has to provide the cursor value, it's not an internal state. We could add the current cursor to the payload for the onEndReached callback).
  • I haven't done much so far. I've added a few props here and there and some hooks to the OptionsContainer, but it's not functional whatsoever. Storybook crashes right now when it's trying to render a Transfer component, so there must be something going wrong.
  • I've also made some changes to the Transfer story. I think these can be kept as a starting point, but the other changes could be omitted as there's really not much and I'm struggling with understand what I was trying to do there..