search

dhis2 / ui-core

:no_entry: [DEPRECATED] Please refer to https://github.com/dhis2/ui
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

fix(MultiSelect): use dense chips for selections in input #875

Closed cooper-joe closed 4 years ago

cooper-joe commented 4 years ago

This PR changes the Chip type used in a MultiSelect. It adds a dense prop to the Chip.

Note: is this the correct conventional commit message type? It's not a fix: because this was not a bug, but is there something before feat:, more like...adjustment:? 😉

cooper-joe commented 4 years ago

@edoardo This is the change you are waiting on for Data Visualizer YoY controls.

Mohammer5 commented 4 years ago

@varl @ismay should this go into ui-core or ui?

cypress[bot] commented 4 years ago


Test summary

258 • 0 • 0 • 0

Run details
Project ui-core
Status Passed
Commit 65453b87a4
Started Apr 15, 2020 9:31 AM
Ended Apr 15, 2020 9:38 AM
Duration 07:16 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 78

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

ismay commented 4 years ago

I'd personally say ui@alpha, the NoticeBox is also there for example. Otherwise we have changes in ui-core that we'd have to pull into ui. But I don't know what @varl prefers. Plus it depends on the timeline for this change (it will take a bit until the ui stable release), ui-core could be released r.n.

varl commented 4 years ago

I'd say that this is a fix:, as a fix doesn't have to be a straight up bug fix, it can be a design fix or something else that fixes something without introducing a new feature.

As for where it goes, merging from ui-core to ui is relatively straight forward, so this can go here as it is being waited on.

cooper-joe commented 4 years ago

I'd say that this is a fix:, as a fix doesn't have to be a straight up bug fix, it can be a design fix or something else that fixes something without introducing a new feature.

Thanks for the clarification @varl, that makes sense to me now. I've changed the commit message.

dhis2-bot commented 4 years ago

:tada: This PR is included in version 4.17.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: