Open HendrikThePendric opened 5 years ago
Great work @HendrikThePendric, it's good to get an overview of what will be included. I've been working in the old/new Tracker apps and I've seen some other types of data being captured there. I'm not sure if they are generic enough to be included in ui-forms, but for discussion:
File
type you listed above, but different in how it is displayed: a thumbnail is shown when an image is set / is selected for upload.There are some other defined types such as URL, Email, but they could be handled with validation on a text-input.
I've found the following 2 input groups in the import-export app, we need to think about how we'd structure the component api to allow this while keeping everything being flexible.
Ideally this is something that's not built into the component and is simple to set up with what ui-forms
provides:
(it has select all
/ deselect all
buttons)
(it has select all
/ deselect all
buttons)
Thanks for providing that example @Mohammer5
Ideally this is something that's not built into the component and is simple to set up with what ui-forms provides:
I agree that that this type of component should be a custom form component that is easy to build. However, I disagree that is should be build from components in ui-forms
. I would like to use this distinction:
ui-forms
, by definition, are ready to use as a component
prop on a Field
. They are stand-alone and fully composed of components from ui-core
. ui-forms
should not expose building-blocks to build custom form-components withui-core
should contain all the building blocks to easily construct a custom form-component with, in the similar way that the components in ui-forms
have been built.@HendrikThePendric sorry for not making that clear, I 100% agree with you!
Just wanted to say that ui-forms
shouldn't put a spoke in the dev's wheel and should offer components that are effortlessly composable with ui-core
/ui-widget
We should discuss and document which components are needed in this repo. I will suggest a list below, which can be be discussed and edited until we are all happy with it:
File
type you listed above, but different in how it is displayed: a thumbnail is shown when an image is set / is selected for upload.Obviously, for some of these there is still a long road ahead, but I just wanted to make this a comprehensive list.
Reg. multi-select: as @cooper-joe @Mohammer5 and I discussed on Slack, we already have multi-select component, which is the GroupEditor.
Edit (by @Mohammer5):
I converted the list of this issue into a checkbox list. Let's make this a living issue that reflects the current state of development and decision making.
Edit (by @HendrikThePendric):
Added the points that @cooper-joe suggested to the living list
Edit (by @HendrikThePendric) (9-12-2019):
Updated the list to reflect the current progress (PR still in review ATM)