cypress[bot]
commented
5 months ago 106 failed tests on run #3422 ↗︎
 106 |
 478 |
 0 |
 0 |
 0 |
Details:
| chore: remove legacy scripts and GH workflow bandaids | |||
| Project: ui | Commit: f51318f1f5 |
||
| Status: Failed | Duration: 09:08 💡 | ||
| Started: Jun 12, 2024 3:21 AM | Ended: Jun 12, 2024 3:30 AM | ||
components/alert/src/alert-bar/features/api.feature • 1 failed test • e2e
View Output
| Test | Artifacts | |
|---|---|---|
| AlertBar API > AlertBar will call the onHidden cb when hidden |
Test Replay
Screenshots
|
|
components/alert/src/alert-bar/features/hide.feature • 1 failed test • e2e
View Output
| Test | Artifacts | |
|---|---|---|
| Hiding the AlertBar > The hidden prop is toggled |
Test Replay
Screenshots
|
|
components/header-bar/src/features/the_headerbar_can_display_online_status.feature • 1 failed test • e2e
View Output
| Test | Artifacts | |
|---|---|---|
| The HeaderBar can display online status > The HeaderBar displays an offline status when offline |
Test Replay
Screenshots
|
|
components/tooltip/src/features/visibility_toggling.feature • 1 failed test • e2e
View Output
| Test | Artifacts | |
|---|---|---|
| Tooltip visibility toggling > Showing when Tooltip is on top of element |
Test Replay
Screenshots
|
|
components/select/src/multi-select/features/position.feature • 3 failed tests • e2e
View Output
The first 5 failed specs are shown, see all 80 specs in Cypress Cloud.
dhis2-bot
Implements LIBS-588
Description
This PR updates storybook to the latest version, which allows us to use node v20 and get rid of the
*:legacyscripts in the rootpackage.json.This PR changes A LOT of files, so I suppose it doesn't make sense to check the changed lines. Here's what I did and needs to be reviewed / approved (I omitted some changes, you can look at the commit history for more details):
Changed production story file names Storybook now expects that files containing stories end with
.stories.js, which breaks our system of having.stories.e2e.jsand.stories.js. Simply renaming the test stories to.e2e.stories.jswould include them in our demo storybook. So the files extensions are now.e2e.stories.jsfor the test storybook and.prod.stories.jsfor our live demo storybook.New storybook api The start commands had to be adjusted. So basically every
package.jsonwas touched.React version I aligned the react versions in the
package.jsonfiles with the version defined in the rootpackage.json. The root one had a higher version defined, so that's the one I used.Markup / CSS changes The new version of storybook uses a slighly different markup and injects more html into the stories than previously. Because of that I had to change some css rules (e.g. like this) and selectors in cypress tests (like this or this, most of the time this was the case for selectors like
cy.get('a')orcy.get('button')).Circular dependencies I fixed some circular dependencies where imports went through a sibling/parent
index.js, see here.storybook references in docs removed See here. Thanks to @kabaros who figured this out. This was necessary because the build step was failing because of this. TODO: This needs a follow-up ticket because I think we're hiding previously accessible documentation from the user now.
Removed legacy scripts and GH workflow bandaids See here. These were added when upgrading cypress & the nodejs version, with the idea that this PR will remove them again.
Adjust e2e story names and how they're
cy.visited See here. This is a rather large change, but it should be enough to take a look at the first few files.Open issues
storybook-addon-jsxNot working since @^7 This addon hasn't been updated since breaking changes in the addon api were introduced in version 7. There is an open issue which described possible solutions I haven't explored yet: storybookjs/addon-jsx#184 TODO: This needs a follow-up ticket, someone needs to investigate whether there's an alternative approach we can use to get the same / similar resultsThe "Code" tab is loading forever Right now it just says "Loading source...". This is what previously was the "Story" tab, not sure why it has a different label. On the README of that plugin, you can still see "Source" as the label TODO: This needs a follow-up ticket. Maybe it happens because we have custom story paths, but I haven't figured it out.
The "Accessibility" tab is loading forever Right now it just says "Please wait while the accessibility scan is running ..." TODO: This needs a follow-up ticket. Just like the issue above, this could happen because we have custom story paths, but that's just an uneducated guess.