Closed d-rita closed 3 months ago
🚀 Deployed on https://pr-1533--dhis2-ui.netlify.app
Thanks @d-rita . Looks good to me. I only have some minor comments above
There definitely was a bit more to this task. 😅 Thank you for the review @flaminic and @kabaros. 🎉
as discussed privately, it'd be good to:
- memoise
childrenToRender
to make sure we're not recalculating it unnecessarily- add some comments for the reasons for the extra checks (handling warning when passing regular html etc...)
but this can be done in the subsequent PR
I have implemented this feedback in this PR. I have also added the menu children role checks and warning if none is provided as was discussed.
:tada: This PR is included in version 9.9.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Implements LIBS-623
Description
This feature handles keyboard accessibility of the menu and its children components in the following ways:
Checklist