search

dhis2 / ui

Components and related resources for the DHIS2 design system
https://ui.dhis2.nu
BSD 3-Clause "New" or "Revised" License
40 stars 15 forks source link

docs: fix storybook input error #1594

Closed Topener closed 1 month ago

Topener commented 1 month ago

Fixes an error introduced with https://github.com/dhis2/ui/pull/1590/ causing an error in storybook prod. Implements libs-674

Specifically tagging @KaiVandivier to check this as the circular dependency issue sounds like it needed solving too

dhis2-bot commented 1 month ago

🚀 Deployed on https://pr-1594--dhis2-ui.netlify.app

Mohammer5 commented 1 month ago

This seems wrong to me. The component is within the @dhis2-ui/input library, so importing a component from itself via it's module name shouldn't be happening.

If there is a circular dependency, meaning that src/input imports from src/input-field, that what should be fixed instead as that shouldn't be happening

amcgee commented 1 month ago

It was a bit convoluted but I found the underlying issue and fixed it in #1602 - agree it's better not to import internal dependencies through the external package export

Topener commented 1 month ago

Closing this in favour of the better fix