Closed Topener closed 1 month ago
🚀 Deployed on https://pr-1594--dhis2-ui.netlify.app
This seems wrong to me. The component is within the @dhis2-ui/input
library, so importing a component from itself via it's module name shouldn't be happening.
If there is a circular dependency, meaning that src/input
imports from src/input-field
, that what should be fixed instead as that shouldn't be happening
It was a bit convoluted but I found the underlying issue and fixed it in #1602 - agree it's better not to import internal dependencies through the external package export
Closing this in favour of the better fix
Fixes an error introduced with https://github.com/dhis2/ui/pull/1590/ causing an error in storybook prod. Implements libs-674
Specifically tagging @KaiVandivier to check this as the circular dependency issue sounds like it needed solving too