search

dhiway / cord-agent-app-v1

Agent (REST API endpoint) for cord.js sdk
Apache License 2.0
9 stars 7 forks source link

change directory structure #20

Closed ishivanshgoel closed 1 year ago

ishivanshgoel commented 2 years ago
  1. Incorporated changes in directory structure as discussed in #16
  2. Resolved merge conflicts & followed git practice as suggested in #18
amarts commented 2 years ago

I wanted to get the CI done before checking on this.

Also fixed a minor bug in recordUpdate. If its possible to rebase to main once and do a force push, I will review the PR.

ishivanshgoel commented 2 years ago

@amarts updated

amarts commented 2 years ago

@ishivanshgoel good job! Considering this is a big change, I would like to tag before this change. Also I am working with one app developer to finish a PoC with existing code, and hence will hold it off for another week, before we complete that. Expect some minor bug fixes like #24 etc to come in before this is merged.

amarts commented 2 years ago

Good to go now. Need a rebase with few changes done with 'recordShow' method.

ishivanshgoel commented 2 years ago

It's updated @amarts

ishivanshgoel commented 1 year ago

@amarts any improvement required for this PR?