dhiway / cord.js

Cord JS API
Apache License 2.0
36 stars 48 forks source link

stream.update() : implement methods to handle content update without changing identifier #112

Closed adi-a11y closed 1 year ago

adi-a11y commented 1 year ago

Modified demo and added a file(updateDocument.ts) in the utils.

Delegate prepares a new content in the demo and calls the updateStream method in the updateDocument.ts. updateStream method in turn calls the updateFromContent method in the Document.ts.

This PR has been initiated in response to the reviews of - https://github.com/dhiway/cord.js/pull/108.

amarts commented 1 year ago
➤ YN0000: src/document/Document.ts(32,17): error TS6133: 'bool' is declared but its value is never read.
➤ YN0000: The command failed for workspaces that are depended upon by other workspaces; can't satisfy the dependency graph
➤ YN0000: Failed with errors in 1m 39s
adi-a11y commented 1 year ago

code changes LGTM.

Comment on git commit message.

I said I need notification on merge requiring a release, not in subject or body of commit message.

Subject of commit/PR and body / description should always be about the changes done in PR. You can notify requirement of the release as a separate commit, or as a label. Idea is, a single developer doesn't decide when the project makes a release, but the changes requiring release should be tagged.

Noted. Thank you

adi-a11y commented 1 year ago
➤ YN0000: src/document/Document.ts(32,17): error TS6133: 'bool' is declared but its value is never read.
➤ YN0000: The command failed for workspaces that are depended upon by other workspaces; can't satisfy the dependency graph
➤ YN0000: Failed with errors in 1m 39s

Resolved this