Asset: Separate preparation of creation of VC Asset from dispatch

dhiway / cord.js

Cord JS API

Apache License 2.0

34 stars 46 forks source link

Asset: Separate preparation of creation of VC Asset from dispatch #215

Open masterismail opened 2 months ago

masterismail commented 2 months ago

fixes #213

masterismail commented 2 months ago

@vatsa287 @amarts please review.

amarts commented 2 months ago

Ah! anyways, I see some merge conflicts here, can you rebase the whole PR ?

masterismail commented 2 months ago

Nitpick: A good PR should implement only focused area, and fix whitespace issues only in the related area. For fixing any other lines, either send them as a separate PR or separate commit in the same PR (ie, one PR can have multiple commits) so for reviewer, it is easier to focus on the 'logic' changes.

That practise helps in getting PRs reviewed quickly.

Resolved the merged conflict, thank you for the feedback ! I'll keep PRs more focused in the future.