search

dhlab-basel / JDNConvertibleCalendar

Different calendars can be freely converted using Julian Day Number
GNU Affero General Public License v3.0
4 stars 3 forks source link

Support for Hijri/Islamic calendar #5

Closed AlQuraian closed 5 years ago

AlQuraian commented 6 years ago

Thank you for this promising project and for the integration with Angular. It would be great if you add support to the Hijri or Islamic calendar.

If there's a way I can help please give us some guidance.

Thanks again.

tobiasschweizer commented 6 years ago

Hi

We definitely plan to add support for the Islamic calendar.

We need to make another subclass of JDNConvertibleCalendar (in JDNConvertibleCalendarModule) and implement the conversions from and to Julian Day (in JDNConvertibleConversionModule).

It would be great if you could take part in the reviewing process of that upcoming PR.

Thanks a lot!

Tobias

tobiasschweizer commented 5 years ago

@AlQuraian There is an open PR #10 now supporting the conversion from and to Islamic calendar dates.