search

dhlab-basel / alephmarcreader

Python Library to read Marc obtained from Aleph
GNU Affero General Public License v3.0
1 stars 0 forks source link

Handle multiple occurrence of subfields #13

Closed tobiasschweizer closed 5 years ago

tobiasschweizer commented 5 years ago

resolves #11

tobiasschweizer commented 5 years ago

@BalduinLandolt It would be nice to have the MarcXML file, too.

BalduinLandolt commented 5 years ago

I added Sample Data (both AlephX and Marc21) for tests for four more letters:

With that, we have everything covered in our tests, except:

I guess we can live with that, right?

MarcXML files should follow soon.

tobiasschweizer commented 5 years ago

@BalduinLandolt Could you add the test test_recipient_with_multiple_roles for MarcXML?

Then we can go on add more test cases in all implementations.

BalduinLandolt commented 5 years ago

@BalduinLandolt Could you add the test test_recipient_with_multiple_roles for MarcXML?

Then we can go on add more test cases in all implementations.

Timewise, probably not before tomorrow afternoon.

BalduinLandolt commented 5 years ago

Oh... I realize now... this has been waiting for my review all along, right? ^^

tobiasschweizer commented 5 years ago

@BalduinLandolt Could you create subfolders in sample_data for Marc21, MarcXML, and AlephX files and adapt the path in the tests? Thank you!

tobiasschweizer commented 5 years ago

@BalduinLandolt Thanks a lot!