search

dhleong / judo

A more elegant way to play in the MUD
19 stars 2 forks source link

Consider alternate rendering backends #98

Open dhleong opened 4 years ago

dhleong commented 4 years ago

JLine still doesn't actually support 24-bit true color (in fact, its conversion from RGB ANSI to their internal AttributedStyle seems broken—it's what our conversion from FlavorableCharSequence to their AttributedString for rendering is based on, and the results (from a branch for #90) are garbage:

Screen Shot 2020-01-01 at 6 46 26 PM

vs this, using their Colors.roundRgbColor:

Screen Shot 2020-01-01 at 6 47 59 PM

Laterna, for example, has classes to support RGB color, but it's unclear whether their abstraction will round down on terminals that don't support it....

dhleong commented 4 years ago

Just did an experiment and Lanterna does not automatically round down RGB to a supported color, so we'd need a translation layer that can respect the terminal's capabilities....