search

dhleong / playactor

play around with your playstation devices
146 stars 12 forks source link

Can't find PS5 on network #63

Open Aioros opened 9 months ago

Aioros commented 9 months ago

Fairly simple description of the issue, when I try playactor browse, nothing is found. The output of playactor browse --debug shows the discovery pings (listening on 0.0.0.0) but no replies. I do have multiple network interfaces, but using --bind-address with the correct adapter has the same results. Judging from the output of other tools I tried, I think my consoles are just not replying to UPnP/SSDP discovery pings (while other devices in network do, like smart TVs or light bulbs). Any idea why that would be the case?

EDIT: quick update, I'm trying to troubleshoot with Wireshark. At the moment, it seems like the pings are going out to the wrong network interface, so not sure if the --bind-address parameter is working correctly. I'll update if I find anything useful.

Aioros commented 9 months ago

Ok, I believe I found a reasonable reason for this issue: in browse.ts, we have a discovery.discover() that I think should actually be discovery.discover(options.networkConfig). This allows the --bind-address and --bind-port options to flow. Let me know what you think.

dhleong commented 9 months ago

PR is welcome if that fixes it! I don't have a great way to test, but that does sound reasonable.

Aioros commented 9 months ago

I just created pull request #64, hope it's useful. The change did solve the issue for me, by the way, so feel free to close this issue whenever you prefer.