dhmay / jamstats

Tools for making plots on roller derby scoreboard data and following live game data
https://jamstats.net
GNU General Public License v2.0
19 stars 2 forks source link

Additional enhancements to Caller Dashboard and Team Penalty Counts dashboard #138

Closed ScottChicken closed 1 year ago

ScottChicken commented 1 year ago

What version of the tools are you running, and how? Windows version 1.1.3

Is your feature request related to a problem? Please describe. Ideas for additional enhancements to the "Caller Dashboard"

Describe the solution you'd like Additional features / edits to the layout of some of the Dashboards:

dhmay commented 1 year ago

Most of these are pretty achievable. This one:

Can you add the count # into the bars? That would make it easier than having to correlate to the axis at the bottom

has already been done in my last two builds:

image

Does that layout work for you?

ScottChicken commented 1 year ago

Ah, yeah, didn't see that one - I was looking at the Team Penalty Counts board - looks like this: image Kind of a summary for the team as a whole rather than for the skaters.

dhmay commented 1 year ago

Implemented: differential row, removing columns, penalty counts on skater plot.

bullseye555 commented 1 year ago

CRG colours rows Yellow for 5, Amber for 6, and Red for fouled out [or expelled] (it actually looks at the Foul Out number which is in the JSON somewhere in the rulesets and uses that -2 for Yellow, -1 for Amber and -0 for Red)

So I'd suggest using that logic for consistency

dhmay commented 1 year ago

Do you want a numeric penalty count for each skater, too? I shortened some column names, so there's a little more room for that:

image
bullseye555 commented 1 year ago

IMO, that would be useful - so yes

dhmay commented 1 year ago

That'll make it easier -- I'll just color the penalty count, so it'll be clear what the color refers to.

dhmay commented 1 year ago

Implemented: team penalty count number on team penalty plot:

image

Build: https://github.com/dhmay/jamstats/actions/runs/4591107051

dhmay commented 1 year ago

I added colored penalty counts to the skater table in the dashboard: https://github.com/dhmay/jamstats/actions/runs/4591205510 It's getting a bit crowded, now.

That covers all the enhancements you requested, @ScottChicken , except the new UI to count penalties per skater. Can I ask does the "[Team X] Skaters" plot already do that for you? The only thing that doesn't give you that you asked for, I think, is color-coding on the counts. But the top-penalty skaters are at the top, and their penalty count is given.

Closing. Reopen if you'd like any more tweaks!

dhmay commented 1 year ago

Note: I implemented this as:

1-4 penalties: black 5 penalties: yellow 6 penalties: orange 7+ penalties: red

Do you think that's good enough?

bullseye555 commented 1 year ago

Should be fine - I'd suggested adding documentation just to state that it's codes that way, just incase someone is using it in a game with reduced number of penalties to foul out