Closed ScottChicken closed 1 year ago
Is this request for basically the Jammers plot, but for both teams together instead of separated?
That could be a lot of info in one plot (though I think a plot would be easier to parse than a table. Should I maybe switch the orientation so each jammer has a column, rather than a row?
My brain generally goes to tables because for the conversation when calling the bout I need numbers rather than a chart. So I was thinking something like this:
Team A | Team B | |||||||||||||
# | Name | Jams | Points | Lead % | Lead # | Lost # | # | Name | Jams | Points | Lead % | Lead # | Lost # | |
72 | Cholula | 5 | 27 | 60 | 3 | 1 | 5 | Sunny Ono | 8 | 40 | 25 | 2 | 0 | |
83 | Panda | 7 | 42 | 71 | 5 | 0 | 09 | Vampyra | 7 | 32 | 29 | 2 | 0 | |
709 | Kiwi | 10 | 53 | 80 | 8 | 0 | 247 | Pia Mess | 7 | 17 | 29 | 2 | 0 |
What do you think about sorting? By # jams jammed, maybe, or by points, or by skater number? (I should really make it possible to sort however you want, but that'll have to be a future iteration)
Implemented, sorted by jammer #. It's a lot of information in one page:
Is that going to work for you? Would you want to sacrifice any of those columns for simplicity?
Let me know if you prefer a different sort order.
This build artifact contains both the jammers table and the skater penalty counts table enhancements.
I could also collapse the "Number" and "Jammer" columns into one column to save a little space. What do you think?
Yeah, collapsing number and jammer into one column would work, as long as the order is still by jammer number. It's busy but I think useful. And good to remember that it's not going to be THAT much data since most teams only run a 3-5 person rotation.
Which brings up another question: would this include Pivots who took the star, or just people who started the jam as jammer?
Sorry I'm late getting to this...it was graduation weekend for the youngest so I haven't been able to look at e-mail on a computer since like Thursday.
On Sun, Jun 11, 2023 at 5:02 PM Damon May @.***> wrote:
I could also collapse the "Number" and "Jammer" columns into one column to save a little space. What do you think?
— Reply to this email directly, view it on GitHub https://github.com/dhmay/jamstats/issues/145#issuecomment-1586385105, or unsubscribe https://github.com/notifications/unsubscribe-auth/A65NUKKIYP72LIN64YVRJZLXKZMB3ANCNFSM6AAAAAAYQ6HSIQ . You are receiving this because you authored the thread.Message ID: @.***>
-- Scott Chicken (he/him) Roller Derby Announcer Jet City Roller Derby http://jetcityrollerderby.com Rat City Roller Derby http://ratcityrollergirls.com Seattle Derby Brats http://seattlederbybrats.com/
I made that small visual change (combined Number and Jammer columns, still sorted by number):
Currently, this table only includes skaters who started at least one jam as jammer, and, for those skaters, it will only show the points they earned during jams when they started the jam. And, I just realized, it will misattribute any points earned by a pivot they hand the star to to them.
Splitting out those points properly is very much related to #144. Seems like I really should do that, eh?
This same issue also affects the Jammers plots. I'll fix it there, too, and track that work here.
Note to self: it looks like there are rows like this in the json:
"ScoreBoard.Game(6b0dbb90-30fb-4887-a5e4-d09af850f595).Period(2).Jam(11).TeamJam(2).AfterSPScore" : 14,
I should just be able to gather those rows, decrement that jam's first jammer's score by that value, and increment the pivot's score by that value, creating a new row for them if they don't already have one.
Fixed in this artifact, @ScottChicken . Now, the correct points should be attributed to the jammer who started the jam and the pivot who took the star. Affects both the new table and the jammer plots.
What version of the tools are you running, and how? Version 1.2.1
Describe the solution you'd like Create a new page to compare jammers between the teams