search

dhmay / jamstats

Tools for making plots on roller derby scoreboard data and following live game data
https://jamstats.net
GNU General Public License v2.0
19 stars 2 forks source link

JamStats not connecting to scoreboard server #156

Closed ScottChicken closed 1 year ago

ScottChicken commented 1 year ago

Describe the bug Was attempting to connect to the "Remote Studio" scoreboard for the Golden Bowl on Saturday and got the following errors in the JamStats window:

jamstats version 1.3.0, by Damon May Connecting to server score.pdxspeedbump.com, port 443... Mode not specified. Inferred mode web Using theme white

Starting jamstats server... Point your browser to: http://localhost:8080

Opened connection. 2023-09-09 17:30:08,387 | jamstats.io.scoreboard_server_io | INFO: Opened connection. Failed to update game data from server: 'DataFrame' object has no attribute 'Id' EXC: Traceback (most recent call last): EXC: File "jamstats\web\statserver.py", line 250, in index EXC: File "jamstats\data\json_to_pandas.py", line 40, in load_json_derby_game EXC: File "jamstats\data\json_to_pandas.py", line 478, in extract_roster EXC: File "pandas\core\generic.py", line 5487, in getattr EXC: AttributeError: 'DataFrame' object has no attribute 'Id'

To Reproduce Not clear now that the event is over

Expected behavior JamStats would connect to the scoreboard server

Screenshots image

Additional context Scoreboad server link set to score.pdxspeedbump.com:443, SSL box checked

dhmay commented 1 year ago

Shoot! I wonder if it might be a scoreboard version issue. Do you know exactly what version of the scoreboard they were running?

Maximally, could you get them to send you the JSON file from the bout?

ScottChicken commented 1 year ago

I don't know the version, no. @Benjamin Doyle @.***> can you answer that one?

On Sun, Sep 10, 2023, 8:38 PM Damon May @.***> wrote:

Shoot! I wonder if it might be a scoreboard version issue. Do you know exactly what version of the scoreboard they were running?

Maximally, could you get them to send you the JSON file from the bout?

— Reply to this email directly, view it on GitHub https://github.com/dhmay/jamstats/issues/156#issuecomment-1713109474, or unsubscribe https://github.com/notifications/unsubscribe-auth/A65NUKPLCCFMAH22MQIKCYLXZ2BSBANCNFSM6AAAAAA4SU7INE . You are receiving this because you authored the thread.Message ID: @.***>

dhmay commented 1 year ago

OK, two things:

  1. I made a lot of code changes under the hood, back in July. No big functionality impact, but since there's debugging to do I want to make sure you're on the latest code, which is now version 1.3.1, here. Please download that and use it next time. (It won't help with this problem)
  2. I strongly suspect this problem is due to a version of the scoreboard that I haven't seen before, and I need an example of a bleeding-edge scoreboard json to check that out. @bullseye555 , can you help me out?
bullseye555 commented 1 year ago

this is from V2023.2, but there's no data structure changes between this and the current version v2023.3 STATS-2023-06-24_KingstonCityRollersTheRoyals_vs_GeelongRollerDerbyGippslandRangesRollerDerbyPivotCityRanges.json.txt

quadbenjamin commented 1 year ago

I was running CRG v2023.1 in the studio (as proxy), but I don't know what scoreboard version they were running at the tournament. Could have been that they were on an older version so the data they were sending wasn't compatible with JamStats. Attached the json from the last game of that tournament generated through the proxy. state.zip

bullseye555 commented 1 year ago

Thanks @quadbenjamin @dhmay - based on the file, that was 2023.1 (the version is listed as one of the last nodes of the file)

Also, @quadbenjamin - recommend you upgrade to 2023.3, there were a couple of bugs in 2023.1 & .2 that have been fixed in .3

dhmay commented 1 year ago

Interesting! Jamstats works fine on the file @bullseye555 sent (though it puts empty () markers in the roster because no skater pronouns are set... I need to fix that).

But it fails on the file @quadbenjamin sent... but not in the way @ScottChicken described. Instead, (once I fix up the file by putting everything inside a JSON {"state": dictionary entry, which I assume is a weird formatting issue and not an actual change to the file format) I get this when I try to open several of the plots in the webui:

image

I'll dig into what's going on with that file, but I'm nervous that even if I fix that it won't deal with whatever you encountered on Saturday.

dhmay commented 1 year ago

Well, I don't think either of the files you sent contained the problem that you saw on Saturday. I can't fix that without seeing the JSON that caused it, but I put some defensive coding around that issue in this .exe. If you want to start using that, then if you hit the issue again you should see an error message that tells me a little more about what's going on.

Should that happen, if possible (and I know it might not be), please try to capture the JSON file that caused the trouble. If I can get my hands on one of those, I'm pretty sure I can deal with whatever's going on.

On Saturday, did Jamstats work on any of the Golden Bowl games?

dhmay commented 1 year ago

(and has it been working on other tournaments as the new scoreboard versions get more adoption?)

ScottChicken commented 1 year ago

Damon, your link to "version 1.3.1" goes to the 1.3.0 download, which is the one I was running. Is there a newer version with a new version number?

On Sun, Sep 10, 2023 at 10:15 PM Damon May @.***> wrote:

OK, two things:

  1. I made a lot of code changes under the hood, back in July. No big functionality impact, but since there's debugging to do I want to make sure you're on the latest code, which is now version 1.3.1, here https://github.com/dhmay/jamstats/releases/tag/v1.3.0.
  2. I strongly suspect this problem is due to a version of the scoreboard that I haven't seen before, and I need an example of a bleeding-edge scoreboard json to check that out. @bullseye555 https://github.com/bullseye555 , can you help me out?

— Reply to this email directly, view it on GitHub https://github.com/dhmay/jamstats/issues/156#issuecomment-1713178853, or unsubscribe https://github.com/notifications/unsubscribe-auth/A65NUKJIJAG6NQ63OSMTSWDXZ2M6VANCNFSM6AAAAAA4SU7INE . You are receiving this because you authored the thread.Message ID: @.***>

-- Scott Chicken (he/him) Roller Derby Announcer Jet City Roller Derby http://jetcityrollerderby.com Rat City Roller Derby http://ratcityrollergirls.com Seattle Derby Brats http://seattlederbybrats.com/

dhmay commented 1 year ago

Whoops, sorry! Version 1.3.1.

dhmay commented 1 year ago

I'm also going to add better error handling, @ScottChicken . I'll catch the error that caused this problem, and if you get it again it'll give you a way to download the JSON and a link to log a new Jamstats issue and upload it. If I find time to get really fancy, I'll use the github API to automate all that, if the user presses a button.

Then I'll put out a new release and put up a post on the scoreboard FB group, so that anyone who ever gets an error like that again can help me fix it. I'll try to get to all that in the next couple days.

dhmay commented 1 year ago

@ScottChicken , please download the newest release, 1.4.0. If you hit a problem like this again, you should get an error message with a link to download the game json. Then you can log a new issue and upload the game json there.

Also adds the ability to download the game json any time you want, from a left sidebar link.