search

dhmay / jamstats

Tools for making plots on roller derby scoreboard data and following live game data
https://jamstats.net
GNU General Public License v2.0
19 stars 2 forks source link

Penalties being misinterpreted #177

Closed uujfwmnp closed 6 months ago

uujfwmnp commented 6 months ago

Describe the bug Some players have the wrong penalty listed in the output of Jamstats

To Reproduce Add a number of players with various single game penalties in CRG, run the CRG JSON stats through Jamstats (web or PDF)

Expected behavior Correct player penalties shown

Screenshots image image

Additional context I was back-filling penalties into a completed game, the data was not being entered into a live match.

dhmay commented 6 months ago

Thank you for pointing this out! So, it looks like the correct penalties are getting captured, but they're getting associated with the wrong skaters on the right team? That's what I'm inferring from your second image.

uujfwmnp commented 6 months ago

Yep! The mixup only happened with skaters that had a single penalty, but it did not affect all of them.Message ID: <dhmay/jamstats/issues/177/2105941603 @github.com>

dhmay commented 6 months ago

I think I fixed it. The problem was that I was literally just sorting the skater data (name, jams... everything but penalties) by how many penalties they had. No surprise that caused this bug!

I believe I've fixed the problem. Are you on Windows, @uujfwmnp ? If so, could you please try downloading this zipped .exe file, running JamStats from that, and see if it looks fixed to you?

uujfwmnp commented 6 months ago

That did the trick, thank you! The skater data sorting actually did affect more skaters than I realized once I did side-by-side comparisons. I think we can close this ticket. :)

dhmay commented 6 months ago

Great! Fixing in 1.4.12.