Campaign Game Final Screen Improvements

dhmit / democracy_africa

dhmit's spring 2020 project - Democracy and Development: Perspectives from Africa

4 stars 2 forks source link

Campaign Game Final Screen Improvements #115

Closed JasonLin43212 closed 4 years ago

JasonLin43212 commented 4 years ago

Branched off from PR #114

Matched the color of the text in the table of the final screen to whether you have over 50% of the vote from that province
- Once you get to the results screen, the user will know if they won or lost and how much votes they got.
- The try again button renders the modal, but now with a fixed position, so the modal will be in the center no matter where you scroll
- When you click on a province in the final screen, you will be able to see the name of that province as well as a sample of the citizens from that region.

ryaanahmed commented 4 years ago

Looks really good. I think this part...

Once you get to the results screen, the user will know if they won or lost and how much votes they got.

... might need some adjustment, as currently the "You won" or "You lost" is a little stark. Maybe "You got a majority of the electorate" etc. But not blocking merging since this is certainly an improvement, and we can refine from here.