search

dhmit / democracy_africa

dhmit's spring 2020 project - Democracy and Development: Perspectives from Africa
4 stars 2 forks source link

Budget simulator smallupdates #75

Closed bengao01 closed 4 years ago

bengao01 commented 4 years ago

Updated the budget simulator with a few small changes, such as switching the order of a few sliders and making the default allocation to be 20% for each category.

ryaanahmed commented 4 years ago

THANK YOU @amy-lei -- much improved.

This made me notice that there are some small problems here that our current linter isn't catching (e.g., it's let through a few let vars that should be const because they're not being mutated, etc.). I'm going through and adding stricter linting rules on another branch -- as soon as that's merged and merged into this branch, they'll appear as linter failures over here. My fault! But I'll wait to merge this until that's in, so we don't have to cleanup after.

ryaanahmed commented 4 years ago

@amy-lei @bengao01 merged latest version of master with the stricter linter in. Please fix the resulting linter errors, then this is good to merge.