dhmit / gender_analysis

A toolkit for analyzing gendered language across sets of documents
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Removing book-clearing bug from gender_frequency #107

Closed kenalba closed 4 years ago

kenalba commented 4 years ago

This PR:

See https://github.com/dhmit/gender_analysis/issues/98 . After discussion, we agreed that the broken lines were probably vestigial and decided to cut them.

ryaanahmed commented 4 years ago

n.b. this is my first pull request! if I am doing something wrong here, please tell me.

Things to fix:

The commit itself looks good! I'll leave this open just so you can take a whack at fixing the issues in the structure of the PR itself before I merge.

ryaanahmed commented 4 years ago

Better. Please read the docs I linked above and see if you can get this PR to auto close the linked issue.

kenalba commented 4 years ago

... ahem. Yes, sorry, I linked in the body without actually linking. Should be fixed now!

ryaanahmed commented 4 years ago

Looks good!