search

dhmit / gender_analysis

A toolkit for analyzing gendered language across sets of documents
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Clarify helper functions in `gender_adjective.py` #118

Closed samimak37 closed 3 years ago

samimak37 commented 4 years ago

It looks like there are a few different functions in gender_adjective.py (such as this one) that appear to just be helper code for other functions in the file. Do we want these to be user-facing, or should we keep them as internal functions?

In the event that we want them user facing, we should go through and clarify the documentation and/or signatures of a lot of these, as some have ambiguous or confusing naming schemes (consider merge vs merge_raw_results)

MBJean commented 3 years ago

This issue is resolved in the new proximity module (PR #159).