search

dhmit / gender_analysis

A toolkit for analyzing gendered language across sets of documents
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Give `PronounSeries` subject/object fields #132

Closed samimak37 closed 4 years ago

samimak37 commented 4 years ago

For some analysis functions, it would be helpful/necessary for the PronounSeries class to have subject/object distinctions for its pronouns. These will probably need to be optional parameters passed into its constructor

ryaanahmed commented 4 years ago

Good thought. Maybe also singular / plural?

These will probably need to be optional parameters passed into its constructor

My gut instinct is that we should refactor PronounSeries so that these are individual attrs of the class and are mandatory. (Mandatory because so much of what we're doing in this package involves parts of speech.)

ryaanahmed commented 4 years ago

But let's find out if this is necessary as we're doing the work of porting each analytic function over.

samimak37 commented 4 years ago

It looks like in instance_distance.py we're using the object/subject pronouns to do some analysis on the frequency of those pronouns between genders, but that's the only place I've found it (so far)

kenalba commented 4 years ago

None of this shows up in gender_adjective.py as far as I can tell.