search

dhmit / gender_analysis

A toolkit for analyzing gendered language across sets of documents
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Visualization unit tests #142

Closed wilke0818 closed 3 years ago

wilke0818 commented 3 years ago

These tests cover creating metadata-visualizations and usually check that the the files are successfully created with the correct filename and put into the correct directory. The changes in this PR also incorporate changes from #125 but has been structured to more generally create the output directories now and has moved the functionality for this into a common file.

wilke0818 commented 3 years ago

@ryaanahmed fixed the issues with the unit tests that blocked it from passing on Github

codecov-io commented 3 years ago

Codecov Report

Merging #142 (7390b89) into master (e3a14ab) will increase coverage by 6.83%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   44.32%   51.16%   +6.83%     
==========================================
  Files          12       12              
  Lines        1665     1675      +10     
  Branches      367      364       -3     
==========================================
+ Hits          738      857     +119     
+ Misses        876      757     -119     
- Partials       51       61      +10
Impacted Files Coverage Δ
...ender_analysis/analysis/metadata_visualizations.py 84.21% <100.00%> (+77.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3a14ab...7390b89. Read the comment docs.

wilke0818 commented 3 years ago

@ryaanahmed Made the requested changes!

ryaanahmed commented 3 years ago

Changes look good @wilke0818 - much clearer / less duplication.

Linter failures here are all in files heavily edited in #143 so leaving alone per discussion in #145 to avoid giant merge conflicts.

merging!