dhmit / gender_analysis

A toolkit for analyzing gendered language across sets of documents
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Expand `Gender` support and unify analysis functions #143

Closed samimak37 closed 3 years ago

samimak37 commented 3 years ago

This PR changes analysis functions in order to use the new Gender and PronounSeries classes in order to un-binarize the analysis functions, along with tackling some other alpha milestones along the way.

codecov-io commented 3 years ago

Codecov Report

Merging #143 (e066252) into master (9bafdee) will increase coverage by 5.11%. The diff coverage is 40.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   51.16%   56.28%   +5.11%     
==========================================
  Files          12       12              
  Lines        1675     1464     -211     
  Branches      364      361       -3     
==========================================
- Hits          857      824      -33     
+ Misses        757      586     -171     
+ Partials       61       54       -7     
Impacted Files Coverage Δ
gender_analysis/analysis/dunning.py 30.00% <0.00%> (ø)
gender_analysis/analysis/dependency_parsing.py 12.14% <6.25%> (-1.57%) :arrow_down:
gender_analysis/analysis/instance_distance.py 32.60% <8.69%> (-1.98%) :arrow_down:
gender_analysis/analysis/gender_adjective.py 45.27% <44.89%> (+14.89%) :arrow_up:
gender_analysis/analysis/gender_frequency.py 59.33% <57.46%> (+9.69%) :arrow_up:
gender_analysis/gender.py 100.00% <0.00%> (+2.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9bafdee...e066252. Read the comment docs.

ryaanahmed commented 3 years ago

HUGE WORK all! Everything looks solid to me. I'm going to go ahead and merge.