search

dhmit / paris_1970

Fall 2020 Project: This was Paris in 1970
9 stars 5 forks source link

Add photo map to tag view (in progress) #252

Closed irinazoccolini closed 2 years ago

irinazoccolini commented 2 years ago

So far, this PR adds a map to the tag view page. The map displays how many photos are found for the tag in each map square.

I'm currently trying to figure out what should happen when a user clicks on a map square. Should it only state the number of photos for the tag in the map square, or should it also link to a page that shows all the photos with the tag for the map square? Right now, it does the same thing as the main map (links to all the photos in the map square).

Screen Shot 2022-11-01 at 2 11 38 PM
ryaanahmed commented 2 years ago

Right now, it does the same thing as the main map (links to all the photos in the map square).

@irinazoccolini -- I think this is the most sensible thing to do for now. Building a separate page that has the intersection of a map square and a tag probably isn't worth it. Maybe if we had a filtering mechanism for an individual map square...

ryaanahmed commented 2 years ago

@jeffreyshen19's comments here are right on, but since they can be addressed in follow on work, I'm going ahead and merging this in. thanks!