search

dhmit / sonification

15 stars 5 forks source link

Instrument picker #71

Closed ryaanahmed closed 2 years ago

ryaanahmed commented 2 years ago

This PR adds an instrument picker component that switches between the various instruments. It also has a tab for downloading the samples produced by a given module. It also implements this picker in the colors module.

Thanks to @vedadehhc for hacking in the first part of this work.

https://user-images.githubusercontent.com/691117/145246262-81b9d223-c813-4a70-a2ed-772d1c4afe5c.mp4

I've also cleaned up some of the bugs that @vedadehhc noticed over in #66 re: audio contexts not being cleaned up correctly. There are a few edge cases that are still producing crashes in the audio playback after rapidly switching back and forth between tabs of the picker, so I'll continue to investigate, but this should handle most of the common cases.

ryaanahmed commented 2 years ago

Also the UI needs some cleanup, but @anastasia and I are going to be working on that today, so I figured just get this in, and then we'll work on regularizing across the project.

ryaanahmed commented 2 years ago

Chatted with @anastasia offline -- going to self-merge this now and she'll do follow-up cleanup work later.