Closed jjaykim closed 3 years ago
We should indicate in help message that we use data from NA
server
All help message needs to be updated.
eg;
@관전남-jj last_match [summoner name]
Get last match history
We are not 'getting' last match history. We show last_match history stat of summoner
All help message needs to be updated.
eg;
@관전남-jj last_match [summoner name] Get last match history
We are not 'getting' last match history. We show last_match history stat of summoner
@bot.command(name="rank", help="Get rank of summoner")
async def get_rank(ctx, name: str):
@bot.command(name="rank", help="Get rank of summoner")
async def get_rank(ctx, name: str):
help_embed.add_field(
value=f"<@!{bot.user.id}> **{get_rank.name} [summoner name]** \n {get_rank.help}",
)
help_embed.add_field(
value=f"<@!{bot.user.id}> **{get_last_match.name} [summoner name]** \n \
{get_last_match.help}",
)
as you can see these codes, I just quoted the help attribute of each command. should I create a different description of them or change each command's help attribute?
All help message needs to be updated. eg;
@관전남-jj last_match [summoner name] Get last match history
We are not 'getting' last match history. We show last_match history stat of summoner
@bot.command(name="rank", help="Get rank of summoner") async def get_rank(ctx, name: str): @bot.command(name="rank", help="Get rank of summoner") async def get_rank(ctx, name: str): help_embed.add_field( value=f"<@!{bot.user.id}> **{get_rank.name} [summoner name]** \n {get_rank.help}", ) help_embed.add_field( value=f"<@!{bot.user.id}> **{get_last_match.name} [summoner name]** \n \ {get_last_match.help}", )
as you can see these codes, I just quoted the help attribute of each command. should I create a different description of them or change each command's help attribute?
yeah update each command's help attribute
Befor putting PR (put x in bracket if you ran it.);
pylint $(git ls-files '*.py')
passesOverview
remove default help command and then create our custom help command
https://github.com/dhmoon91/discord/issues/5
desktop version
mobile version