dhmoon91 / porobot

0 stars 0 forks source link

refactor, separate create embed func, refactor string formatting #19

Closed dhmoon91 closed 3 years ago

dhmoon91 commented 3 years ago

Befor putting PR (put x in bracket if you ran it.);

[x] Run pylint $(git ls-files '*.py') passes

Overview

Describe your pull request. Attach github issue link

Refactoring:
1. Using helper function to create embed data.
2. Fixing few string formatting to simplify code.
3. Fixing typo; summoner name -> summoner_name
4. Fixing issue with rank image not getting put in as thumbnail.