dhmoon91 / porobot

0 stars 0 forks source link

complete handle each command error #27

Closed jjaykim closed 3 years ago

jjaykim commented 3 years ago

Befor putting PR (put x in bracket if you ran it.);

Overview

Issue https://github.com/dhmoon91/discord/issues/9 For each commend, handle possible errors and if any send a message.

A situation an error can occur in get_rank

A situation an error can occur in get_last_match:

UPDATE on July 11 consider general error cases in the help command

The message of when summoner name not found or inputs more then one summoner name

The message of when occurs other cases of an error (The general error message is the same case as @jung1411's add_summoner, so I brought a sentence)

dhmoon91 commented 3 years ago

@jjaykim merge this if you think it's good to go you have two approvals

jjaykim commented 3 years ago

@jjaykim merge this if you think it's good to go you have two approvals

Yes. I think it's good and also we discussed with this pr on last Tuesday. Should I click squash and merge or will you do it?

dhmoon91 commented 3 years ago

@jjaykim this is your pr dont wait for other people to merge it for you lol