search

dhmoon91 / porobot

0 stars 0 forks source link

Problem with adding, listing, display for Master, GrandMaster and Challenger players #33

Closed jung1411 closed 3 years ago

jung1411 commented 3 years ago

Right now, there's a problem with adding, listing for Master, GrandMaster and Challenger players. It is due to these tier players not having a rank_number ('I', 'II', 'III', 'IV') at the end. There's no Master IV, Challenger IV. It is Master 200 lp, Challenger 800 lp. Forgot to consider this as I was testing with people from Iron to Diamond. I will come back to this to fix these.

jung1411 commented 3 years ago

To do this:

For add command,

  1. add lp points
    • (0~100 lp) for Iron ~ Diamond
    • master, grandmaster, challenger only have lp points starting 0lp for master, around 300lp for grandmaster and 650lp for master
    • these are not fixed lp points as they are assigned to GM or Challenger
    • depending on the ranking not based on how much lp points they have
    • Challenger: 1 ~ 300, GrandMaster: 301 ~ 1000 and rest are Master players
  2. Since Uranked, Master, GrandMaster and Challenger players don't have I, II, III, IV, it must be stored empty for that part

For list command,

  1. Come up with way to display like how 소나봇 displays Master, GrandMaster, Challenger and Unranked players.
    • For unranked, just display "UR" not "Un" image

For *display command,

  1. Currently displaying ranks on unranked players give errors
    • Need to fix this so that information about unranked players are shown
  2. League points should be added in order to differentiate all the skill levels of Master, Grandmaster and Challenger players