search

dhmoon91 / porobot

0 stars 0 forks source link

fixed problems with add, list, rank commands #37

Closed jung1411 closed 3 years ago

jung1411 commented 3 years ago

Befor putting PR (put x in bracket if you ran it.);

Overview

Issue https://github.com/dhmoon91/discord/issues/33

Fixed problems with commands: add, list, display commands:

  1. Problem with add command - no rank number value (I, II, III, IV)

    • League Points (LP) was added in order to make team for top tiers like Master, Grand Master and Challengers as league points were necessary to differentiate the gap between summoners with same tier

  2. Problem with list command: Challenger, Grand Master and Master players shown as C1, G1, M1 as shown below

    image

    • Changed it to Challenger: CH, Grand Master: GM, Master: MA so that it is easier to recognize

    image

  3. Problem with rank command: @관전남 <command> not needed and changes needed in positioning as shown below

    image

    • Removed the @관전남 <command> and changed position between the rank information and All Data from NA server

    image

    image

  4. Problem with rank command: Had errors when trying to display rank for Unranked summoners as shown below

    image

    • Added emblem for unranked tier, set all rank values to zero if unranked as it was complaining how they can't find rank information

    image