search

dhocker / udmx-pyusb

Programming the Anyma uDMX interface using Python and PyUSB
GNU General Public License v3.0
31 stars 5 forks source link

README.MD Mistake #1

Closed featherbear closed 7 years ago

featherbear commented 7 years ago

https://github.com/dhocker/udmx-pyusb/blob/master/pyudmx/pyudmx.py#L121-L130 Channel values are from 1-512

https://github.com/dhocker/udmx-pyusb/blob/master/pyudmx/pyudmx.py#L84 Channel values are from 1-512

In the readme.. dev.send_single_value(0, 255) # sends the value 255 to DMX channel 1 Shouldn't the 0 be a 1?

dhocker commented 7 years ago

You are correct. The first parameter to send_single_value() is supposed to be in the range 1-512. There is a point in the call stack where that value is shifted to 0-511. That's likely where the error originated.

I've updated Readme.md accordingly.

Thanks for reporting this.

On Sun, Feb 5, 2017 at 6:51 AM, Andrew Wong notifications@github.com wrote:

https://github.com/dhocker/udmx-pyusb/blob/master/pyudmx/ pyudmx.py#L121-L130 Channel values are from 1-512

https://github.com/dhocker/udmx-pyusb/blob/master/pyudmx/pyudmx.py#L84 Channel values are from 1-512

In the readme.. dev.send_single_value(0, 255) # sends the value 255 to DMX channel 1 Shouldn't the 0 be a 1?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dhocker/udmx-pyusb/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ABpZ7k9VSjpyPSc8qr9P-mhvakc5bEINks5rZcXVgaJpZM4L3fNw .

-- [dh]