dhoegh / BuildExecutable.jl

Build a standalone executables from a Julia script
Other
156 stars 21 forks source link

Fixes running OSX executable on other systems #12

Closed rofinn closed 8 years ago

rofinn commented 8 years ago

by setting the @rpath to the @executable_path rather than the host julia install directory.

handles issue #11 for OSX

dhoegh commented 8 years ago

Thank you for looking into this issue, sorry for the late response. Unfortunately the change has caused the test's to fail on Travis see: https://travis-ci.org/dhoegh/BuildExecutable.jl/jobs/104242161. Do a Pkg.test("BuildExecutable") pass locally with this change?

rofinn commented 8 years ago

Yeah, the Pkg.test("BuildExecutable") worked fine on my machine... Sorry I forgot to check the travis build, I'll try running the Pkg.test("BuildExecutable") on a fresh VM tonight to confirm it isn't the result of my system configuration.

rofinn commented 8 years ago

Running the tests in a VM also worked. I'm not really sure what is happening on travis that's causing the error, but maybe the travis images are missing something that is pretty standard in osx...?

dhoegh commented 8 years ago

I finally found a fix for the travis test and pushed it to master. Sorry for being slow to find a fix. The fix was indeed very simple, the only thing needed was an slash behind @executable_path. It would be nice if you could checkout master and confirm the fix also work for you.