Separate debug/release build, and few bug fixes

dhoegh / BuildExecutable.jl

Build a standalone executables from a Julia script

Other

156 stars 21 forks source link

Separate debug/release build, and few bug fixes #6

Closed KDr2 closed 8 years ago

KDr2 commented 8 years ago

do NOT build with both release version and debug version at once. If I only have julia or julia-debug in my JULIA_HOME, it fails to build. so I add a option --debug to tell the script to use julia-debug and link against libjulia-debug.(so|dylib).
If I have environment variable JULIA_HOME set, the executable fails to find the sysimage, so I unset JULIA_HOME before initializing julia. Also we can use environment variable JULIA_SYSIMAGE to specify a sysimage to load.

dhoegh commented 8 years ago

My two main concerns are the Appveyor tests need to pass and changes in build_sysimg.jl needs to be upstreamed before I can accept this PR. The build_sysimg.jl is only carried to get the patch from https://github.com/JuliaLang/julia/pull/14018 to fix build_sysimg.jl on OSX to get build_executable.jl working on 0.4. The build_sysimg.jl in this repository should be equivelent to the one on master branch in https://github.com/JuliaLang/julia/.

KDr2 commented 8 years ago

It's weird, both appveryor and travis-ci say the shared object libgit2 is not found, but I downloaded the nightly build, unziped it, libgit2 was there, then ran the testcase, it passed. I also built a julia from its master branch, the test passed too. I'll do some further investigation about this. When the test passes, I'll update the PR https://github.com/JuliaLang/julia/pull/14176 to update the file build_sysimg.jl. Thanks.

KDr2 commented 8 years ago

I found a test failed 14 days ago for the same reason: PR https://github.com/dhoegh/BuildExecutable.jl/pull/3 , https://travis-ci.org/dhoegh/BuildExecutable.jl/jobs/91851037 It searches a shared object file named "libgit2" but not "libgit2.so" and fails.

I tried these actions on a Linux without package libgit2 installed:

build julia from master branch, run the test, passed
download the current nightly julia build (b77587362d), run the test, failed
check out to b77587362d in julia source repo, as the same as the nightly build version, build julia, run test test, passed.

dhoegh commented 8 years ago

Yes, the Travis failure on Julia nightly is not a new failure, but the Appveyor test should pass as it do on master branch in this repository. Edit: The Appveyor failure is not the same failure mode as on Travis.

KDr2 commented 8 years ago

My fault, there's some issues of the c code on windows, and now fixed finally. So we can have this merged after https://github.com/JuliaLang/julia/pull/14176 being merged?

dhoegh commented 8 years ago

This looks good to me when https://github.com/dhoegh/BuildExecutable.jl/pull/6#discussion_r46756481 is fixed.

dhoegh commented 8 years ago

Thank you.