Updates, improvements, cleanup

[JanX2]

Hi David!

this pull request contains changes by others (@w-m and @rpeterson) and myself. Please review and tell me what you think!

Cheers, Jan

[JanX2]

This is just to inform @w-m and @rpeterson of the changes.

[dhoerl]

On 7/20/13 10:11 AM, Jan wrote:

Hi David!

this pull request contains changes by others and myself. Please review and tell me what you think!

Cheers, Jan

Nice - thanks - will get to it Monday!

David

---

    You can merge this Pull Request by running

git pull https://github.com/JanX2/DHlibxls master

Or view, comment on, or merge it at:

https://github.com/dhoerl/DHlibxls/pull/10

    Commit Summary

• commenting out svn co/update
• add MAC OS X target
• number of rows / cols in sheet
• fix release DEBUG flag
• build active arch only
• Support Excel Changes
• Addding git ignore
• Adding @2x icon to TestDHlibxls to quiet Xcode's warning.
• Adding “.gitignore”.
• Merge remote-tracking branch 'refs/remotes/w-m/master'
• Merge remote-tracking branch 'refs/remotes/rpeterson/master'
• Switching to git submodule for libxls.
• Updating README.
• Flagging README as Markdown.
• Removing empty “DHxlsReader”.
• Making 64-bit safe by fixing the variable types.
• Improving handling of text encoding.
• Adding “-xlsReaderWithPath:…” methods.
• Prefixing ivars with underscore as per Apple recommendations.

• Updating README with mention of using the official SVN repository.

  File Changes

• A .gitignore https://github.com/dhoerl/DHlibxls/pull/10/files#diff-0 (19)
• A .gitmodules https://github.com/dhoerl/DHlibxls/pull/10/files#diff-1 (3)
• A DHxlsReader/DHxlsReader-Prefix.pch https://github.com/dhoerl/DHlibxls/pull/10/files#diff-2 (7)
• M DHxlsReaderIOS.xcodeproj/project.pbxproj https://github.com/dhoerl/DHlibxls/pull/10/files#diff-3 (205)
• M DHxlsReaderIOS/DHxlsReaderIOS.h https://github.com/dhoerl/DHlibxls/pull/10/files#diff-4 (22)
• M DHxlsReaderIOS/DHxlsReaderIOS.m https://github.com/dhoerl/DHlibxls/pull/10/files#diff-5 (168)
• A Default-568h@2x.png https://github.com/dhoerl/DHlibxls/pull/10/files#diff-6 (0)
• R README.md https://github.com/dhoerl/DHlibxls/pull/10/files#diff-7 (26)
• M TestDHlibxls.xcodeproj/project.pbxproj https://github.com/dhoerl/DHlibxls/pull/10/files#diff-8 (27)
• M TestDHlibxls/ViewController.m https://github.com/dhoerl/DHlibxls/pull/10/files#diff-9 (2)

• A libxls https://github.com/dhoerl/DHlibxls/pull/10/files#diff-10 (1)

  Patch Links:

• https://github.com/dhoerl/DHlibxls/pull/10.patch
• https://github.com/dhoerl/DHlibxls/pull/10.diff

[JanX2]

Did you get a chance to check this out?

[dhoerl]

Jan been really busy - but I just approved the pull request.

What terminal commands do I need need to run on my Mac to get the changed github files? This is the first pull request I ever got :-)

Also, it looked like you removed "isSheetVisibleAtIndex" but never replaced it in the .h file - but maybe that was my read of the changes.

David

[JanX2]

For most of the usual git commands I tend to use GitX. I know that you have to pull in the changes from the remote and then update your branch using these updates. ;)

In any case, you will have to init the submodule using

git submodule update --init --recursive

(It’s in the README, too)

I can’t see anything wrong with “-isSheetVisibleAtIndex:”. Am I missing something?