search

dhoerl / DHlibxls

Framework to read Excel xls spreadsheets
271 stars 86 forks source link

Rows indexed by shorts, can't parse file larger than 32767 rows. #26

Open mjfuller opened 7 years ago

mjfuller commented 7 years ago

Noticed that there is a segfault in xls_addCell when loading large files. Might there be an easy way to instead index rows with ints or longs? If not, maybe fail gracefully instead. Otherwise this parser is great! lmk if you cannot reproduce this behavior.

dhoerl commented 7 years ago

On 11/14/16 1:51 PM, mjfuller wrote:

Noticed that there is a segfault in xls_addCell when loading large files. Might there be an easy way to instead index rows with ints or longs? If not, maybe fail gracefully instead. Otherwise this parser is great! lmk if you cannot reproduce this behavior.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dhoerl/DHlibxls/issues/26, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxml7PJEJtfD-Fx7dXnaH2C-Herug67ks5q-K2kgaJpZM4Kxq0d.

I haven't looked at this code in years. I suggest using "Analyze" to find incorrect index values (using short instead of unsigned short, etc). Or add some NSLogs(). I really won't have a chance to look at it until December. Its probably something really easy to catch if you spend an hour.

If you do find it let me know via code snippet or pull request.

mjfuller commented 7 years ago

I'll take a look at it and let you know if I find any quick fixes. Thanks.

dhoerl commented 7 years ago

On 11/14/16 2:10 PM, mjfuller wrote:

I'll take a look at it. Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dhoerl/DHlibxls/issues/26#issuecomment-260430595, or mute the thread https://github.com/notifications/unsubscribe-auth/AAxmlwzmyexNUKF9fTcr3zuByFFvMGEwks5q-LIKgaJpZM4Kxq0d.

As the person who took the C based library over, I went to great lengths to be sure indexes used unsigned shorts. But perhaps I missed something in the Objective C wrapper, or there could be something I missed in the library. I tested the library at one point with 60K rows and 256 columns.