search

dhogborg / off-peak

Analyze energy usage
GNU Affero General Public License v3.0
46 stars 10 forks source link

Feature/more time periods #26

Open hendrikdotse opened 1 year ago

hendrikdotse commented 1 year ago

Added: last-year, this-year, last-month as time periods to choose from. Did some dynamic work on titles with new options. Fixed an issue when no data was returned from API you would get stuck in Error state.

Im new to React, so if something is unclear or seems way off or you just don't like the PR please reach out.

regards Hendrik

dhogborg commented 1 year ago

It's a nice start and I have no objections to this - but getting around tibbers limitation of ~ 750 hours per request will be key.

There is if I'm not mistaken there is a cursor property on the consumption and pricing data returned from Tibbers GraphQL API, so using a stepper month-by-month is probably the better option. That will both assure that we don't hammer the API and get people rate limited, and the implementation app-side will be quite a bit easier. The current rate limit is 100 requests per 5 minutes, changing page a couple of times could risk that of complete reloads are performed each time.

hendrikdotse commented 1 year ago

Understand, will read up on tibbers quotas and update with new solution.